Align desk docs with C++ Alexandria - #131
Conversation
README and setup still called Go memory_store the daily driver and listed the chain ledger as remaining. Desk is C++ Release on :8084; Go stays rollback. edit_local_file is hash-bound replace.
There was a problem hiding this comment.
🟡 Changes recommended
The ingestion instructions must target the C++ desk binary, and two documentation nits remain.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates repository documentation to make C++ Alexandria the desk default while retaining Go as rollback.
Changes:
- Refreshes repository maps, architecture docs, and ownership roster.
- Documents C++ build, test, runtime, and ingestion workflows.
- Records hash-bound tools and durable
/chainsupport.
File summaries
| File | Summary |
|---|---|
README.md |
Updates Alexandria map and capability table. Nit (1 vote): distinguish the stdin write executable from the HTTP service. |
godbrain_core/memory_store/README.md |
Marks the Go implementation as rollback. |
godbrain_core/local_ingestion/README.md |
Updates ingestion setup. Moderate (3 votes): ensure the documented command targets the C++ Release executable. |
docs/architecture/setup.md |
Documents C++ prerequisites and runtime setup. |
docs/architecture/reference.md |
Updates component and protocol references. |
docs/architecture/current.md |
Documents the C++ runtime preference. |
docs/AGENT_FACTORY_ROSTER.md |
Updates Alexandria ownership details. |
ARCHITECTURE.md |
Updates the runtime diagram. |
AGENTS.md |
Updates build and validation guidance. Nit (1 vote): clarify the separation between offline ctest and live-write smoke testing. |
Review details
Suppressed comments (2)
AGENTS.md:655
- This parenthetical names a database/test that is not part of the C++ ctest suite.
CMakeLists.txt:102-115registers onlycpp_memory_store_protocol,cpp_rag_eval_self, andcpp_rag_eval_offline, all offline;godbrain_cpp_store_testis only the disposable database used by the separate live-write smoke. Please state the ctest/live-write separation explicitly.
write live `godbrain` from C++ ctest (`godbrain_cpp_store_test` only).
README.md:40
memory-store.exeis the stdin write door and does not bind:8084; onlyrag-service.exeserves that HTTP port. This parenthetical makes the write executable look like an HTTP listener, so separate the two interfaces in the map.
- **[`godbrain_core/cpp_memory_store`](godbrain_core/cpp_memory_store)** is the desk Alexandria write/retrieval path (`memory-store.exe` / `rag-service.exe` on `:8084`). Go [`godbrain_core/memory_store`](godbrain_core/memory_store) stays as rollback with the same doors.
- Files reviewed: 9/9 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| go build -o memory-store.exe .\cmd\memory-store | ||
| Pop-Location | ||
| .\scripts\build_pipeline.ps1 | ||
| python -m godbrain_core.local_ingestion --source-label research .\notes.md |
| material, and sends one strict JSON document per file to the Go Memory Store. It | ||
| does not run inside the privileged kernel and never writes MongoDB directly. | ||
| material, and sends one strict JSON document per file to `memory-store.exe` | ||
| (desk C++ Release, else Go rollback). It does not run inside the privileged |
There was a problem hiding this comment.
[bug] The new parenthetical claims the adapter sends JSON to memory-store.exe as "desk C++ Release, else Go rollback." Source does not resolve that way. godbrain_core/local_ingestion/__main__.py defaults --memory-store to MONGO_STORE_PATH or godbrain_core/memory_store/memory-store.exe (help text still says "Go memory-store"). Kernel/Librarian/Start/Heal prefer build\cpp_memory_store\Release, but this Python door does not. After the new .\scripts\build_pipeline.ps1 example both binaries exist, so following the README still hits the Go rollback copy.
Suggestion: Either restore the Go-default wording (and keep --memory-store / MONGO_STORE_PATH as the override), or change the adapter default to the same C++-then-Go candidate list used by Start/Heal/Librarian. Do not claim C++ Release preference until the Python default matches.
| - Windows, PowerShell (`pwsh` preferred). | ||
| - Visual Studio x64 C++ tools (kernel, Librarian, `run_hidden`). | ||
| - Go version from `godbrain_core/memory_store/go.mod`. | ||
| - CMake 3.25+ and mongo-c-driver at `C:\Tools\mongo-c-driver` (C++ Alexandria). |
There was a problem hiding this comment.
[suggestion] Setup now lists mongo-c-driver at C:\Tools\mongo-c-driver as a hard prerequisite, which matches CMakeLists.txt's default MONGOC_ROOT. Without that driver, build_pipeline.ps1 still configures, but rag-service / rag-rebuild are omitted (protocol-only), so the later .\build\cpp_memory_store\Release\rag-rebuild.exe step fails. The repo already has scripts\Fetch-MongoCDriver.ps1 for that prefix; this setup page never names it.
Suggestion: Point the prerequisite at .\scripts\Fetch-MongoCDriver.ps1 (or a short "if missing, run …" under section 3). Keep the C:\Tools\mongo-c-driver path; that is the CMake default.
Match Librarian/Start/Heal: MONGO_STORE_PATH, then Release, then Go rollback. README already claimed that order.
Goal
Docs lagged the merged cuts (#127–#130). Source is C++
rag-serviceon:8084, Gomemory_storerollback,edit_local_filehash-bound replace, durable/chainalready live.What
Reclaim11 v12 is unchanged (no kit commits since the tag).